wren/src/wren/cli.py (2)

287-309: dry-plan lacks --connection-info option unlike other commands.

The dry-plan command accepts --connection-file but not --connection-info (inline JSON). While this is likely intentional since dry-plan doesn't need full connection credentials, users who are accustomed to passing inline JSON for other commands may be confused.

Consider either adding --connection-info for consistency (ignoring all fields except datasource), or documenting this difference explicitly in the help text.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@wren/src/wren/cli.py` around lines 287 - 309, The dry_plan CLI command
(function dry_plan) is missing the --connection-info / ConnInfoOpt option for
consistency with other commands; add an optional parameter matching the existing
ConnInfoOpt type (or reuse the same CLI annotation used elsewhere) to the
dry_plan signature alongside connection_file, accept inline JSON but only use
its datasource field when resolving datasource (i.e., pass the parsed
connection_info into _load_conn/_resolve_datasource or ignore credentials), and
update the help string to note that only datasource is considered so behavior
matches other commands.

---

50-60: Envelope flattening may discard extra top-level keys.

If the envelope format contains additional top-level keys besides datasource and properties (e.g., metadata fields added by MCP server), they will be silently dropped. If this is intentional, consider adding a brief comment. If not, you may want to merge them:

♻️ Optional: preserve additional top-level keys

 def _normalize_conn(conn: dict) -> dict:
     """Flatten the ``{"datasource": ..., "properties": {...}}`` envelope.

     MCP / web connection files wrap connection fields under a ``properties``
     key.  This normalises both formats into ``{"datasource": ..., **fields}``.
     """
     if "properties" in conn and isinstance(conn["properties"], dict):
         props = conn["properties"]
         props["datasource"] = conn.get("datasource", props.get("datasource"))
+        # Preserve any additional top-level keys (e.g., metadata)
+        for key, value in conn.items():
+            if key not in ("datasource", "properties") and key not in props:
+                props[key] = value
         return props
     return conn

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@wren/src/wren/cli.py` around lines 50 - 60, The _normalize_conn function
currently returns only props when "properties" exists, dropping any other
top-level keys; update it to merge top-level keys with the flattened properties
instead of discarding them: create a new dict that starts from conn (excluding
the original "properties" key) and then update/override it with props, ensure
"datasource" is taken from conn if present else from props, and return this
merged result; modify the logic inside _normalize_conn to build and return that
merged dict while removing "properties".